feat: add client_settings to ChromaDocumentStore#2651
Merged
Conversation
github-actions
Bot
added
integration:chroma
type:documentation
Member
|
Hey @SaraCalla, thanks for the contribution and sorry for the wait. Could you please resolve the conflicts in the meantime? |
anakin87
reviewed
Jan 8, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thank you again. I left some comments.
Have you investigated how Settings interfere with other client parameters?
HttpClient(host: str = "localhost",
port: int = 8000,
settings: my_custom_settings)
anakin87
reviewed
Jan 9, 2026
| try: | ||
| client_kwargs["settings"] = Settings(**self._client_settings) | ||
| except ValueError as e: | ||
| msg = f"Invalid client_settings: {e}" |
Member
There was a problem hiding this comment.
I would report self._client_settings in the error message
Member
|
I will release the new version next week, along with Python 3.9 drop (coming soon). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Added
client_settingsparameter to__init__to allow users to configure the underlying Chroma client's Settings without accessing private attributes.How did you test it?
client_settingsinitializationNotes for the reviewer
I also took the liberty of fixing the async test class marking. Previously, running
hatch run test:unitwould fail because tests required a Chroma server instance. The entireTestDocumentStoreAsyncclass is now marked as@pytest.mark.integration.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.